Skip to content

fix(webpack): fix peerDependencies for css loaders #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2016
Merged

fix(webpack): fix peerDependencies for css loaders #2131

merged 1 commit into from
Aug 8, 2016

Conversation

Awk34
Copy link
Member

@Awk34 Awk34 commented Aug 8, 2016

fixes #2130

@Awk34
Copy link
Member Author

Awk34 commented Aug 8, 2016 •
edited
Loading

I recently deleted all of the Gulp dependencies for CSS compilation. It seems like all of those included their compiler counterparts as dependencies, while the respective Webpack loaders only listed them as peer dependencies (not installed by default, have to manually specify version in your package.json).

@eduardoRoth
Copy link

@Awk34 One test failed:

1 failing

  1) angular-fullstack:app with TypeScript, Mocha + Chai (should) and no server options with a generated endpoint should run server tests successfully:
     AssertionError: expected [Promise] to be fulfilled, but it was rejected with Error {
  cmd: 'gulp test:server',
  code: 7,
  killed: false,
  signal: null,
  message: 'Command failed: gulp test:server\n(node) crypto.createCredentials is deprecated. Use tls.createSecureContext instead.\n(node) crypto.Credentials is deprecated. Use tls.createSecureContext instead.\n\nevents.js:154\n      throw er; // Unhandled \'error\' event\n      ^\nError: listen EADDRINUSE 0.0.0.0:9000\n    at Object.exports._errnoException (util.js:893:11)\n    at exports._exceptionWithHostPort (util.js:916:20)\n    at Server.__dirname.Server.Server._listen2 (net.js:1246:14)\n    at listen (net.js:1282:10)\n    at net.js:1391:9\n    at _combinedTickCallback (internal/process/next_tick.js:77:11)\n    at process._tickDomainCallback (internal/process/next_tick.js:122:9)\n'
}
      at Assertion.fail (node_modules/should/cjs/should.js:326:17)
      at next$onReject (node_modules/should/cjs/should.js:1511:14)
      at tryCatcher (node_modules/bluebird/js/release/util.js:16:23)
      at Promise._settlePromiseFromHandler (node_modules/bluebird/js/release/promise.js:504:31)
      at Promise._settlePromise (node_modules/bluebird/js/release/promise.js:561:18)
      at Promise._settlePromise0 (node_modules/bluebird/js/release/promise.js:606:10)
      at Promise._settlePromises (node_modules/bluebird/js/release/promise.js:681:18)
      at Async._drainQueue (node_modules/bluebird/js/release/async.js:138:16)
      at Async._drainQueues (node_modules/bluebird/js/release/async.js:148:10)
      at Immediate.Async.drainQueues [as _onImmediate] (node_modules/bluebird/js/release/async.js:17:14)

@Awk34
Copy link
Member Author

Awk34 commented Aug 8, 2016 •
edited
Loading

@eduardoRoth yeah, that's a CI issue I've known about (race condition), haven't gotten around to fixing it.

@Awk34 Awk34 merged commit cd10954 into master Aug 8, 2016
@Awk34 Awk34 deleted the fix/css-loaders branch August 11, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug chore semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENOENT and can't find module on 4.0.0 while running gulp serve
2 participants
@Awk34 @eduardoRoth